summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Laight <david.laight.linux@gmail.com>2025-11-19 22:41:10 +0000
committerHerbert Xu <herbert@gondor.apana.org.au>2025-11-24 17:44:14 +0800
commit0f8ead58b6dce9520fc3f9ff7f943bb0627a7a19 (patch)
tree3514465756fa9e67f505a7b4c204f2537868f7b4
parent6c5d5b6dc5eb966e86a92e6587ccca1ec1e392e1 (diff)
hwrng: core - use min3() instead of nested min_t()
min_t(u16, a, b) is likely to discard significant bits. Replace: min_t(u16, min_t(u16, default_quality, 1024), rng->quality ?: 1024); with: min3(default_quality, 1024, rng->quality ?: 1024); Signed-off-by: David Laight <david.laight.linux@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/char/hw_random/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 56d888bebe0c..96d7fe41b373 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -545,7 +545,7 @@ int hwrng_register(struct hwrng *rng)
init_completion(&rng->dying);
/* Adjust quality field to always have a proper value */
- rng->quality = min_t(u16, min_t(u16, default_quality, 1024), rng->quality ?: 1024);
+ rng->quality = min3(default_quality, 1024, rng->quality ?: 1024);
if (!cur_rng_set_by_user &&
(!current_rng || rng->quality > current_rng->quality)) {