diff options
| author | Steven Price <steven.price@arm.com> | 2025-11-24 11:20:38 +0000 |
|---|---|---|
| committer | Steven Price <steven.price@arm.com> | 2025-11-26 11:18:18 +0000 |
| commit | 922682d48d628c6c5540da2eb5481f7f7694ce48 (patch) | |
| tree | 6621fe0b9b3228764b36aaf758075111945dde34 | |
| parent | e20c6260474c45f66c636a50d5b8801759ffe09e (diff) | |
drm/gem: Correct error condition in drm_gem_objects_lookup
When vmemdup_array_user() fails, 'handles' is set to a negative error
code and no memory is allocated. So the call to kvfree() should not
happen. Instead just return early with the error code.
Fixes: cb77b79abf5f ("drm/gem: Use vmemdup_array_user in drm_gem_objects_lookup")
Signed-off-by: Steven Price <steven.price@arm.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Link: https://patch.msgid.link/20251124112039.117748-1-steven.price@arm.com
| -rw-r--r-- | drivers/gpu/drm/drm_gem.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 68168d58a7c8..efc79bbf3c73 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -798,13 +798,10 @@ int drm_gem_objects_lookup(struct drm_file *filp, void __user *bo_handles, *objs_out = objs; handles = vmemdup_array_user(bo_handles, count, sizeof(u32)); - if (IS_ERR(handles)) { - ret = PTR_ERR(handles); - goto out; - } + if (IS_ERR(handles)) + return PTR_ERR(handles); ret = objects_lookup(filp, handles, count, objs); -out: kvfree(handles); return ret; |