diff options
| author | Davidlohr Bueso <dave@stgolabs.net> | 2025-11-18 13:07:06 -0800 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-11-19 12:17:28 +0100 |
| commit | c29383a874ee86af1c68488f15f88544140414fe (patch) | |
| tree | 28005c8559e15cbc7ef89da61abe2a7d108929b6 | |
| parent | 030e86dfdaa789dd2e2e481d7118979a9d1f8f4e (diff) | |
watch_queue: Use local kmap in post_one_notification()
Replace the now deprecated kmap_atomic() with kmap_local_page().
Optimize for the non-highmem cases and avoid disabling preemption and
pagefaults, the caller's context is atomic anyway, but that is irrelevant
to kmap. The memcpy itself does not require any such semantics and the
mapping would hold valid across context switches anyway. Further, highmem
is planned to to be removed[1].
[1] https://lore.kernel.org/all/4ff89b72-03ff-4447-9d21-dd6a5fe1550f@app.fastmail.com/
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://patch.msgid.link/20251118210706.1816303-1-dave@stgolabs.net
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | kernel/watch_queue.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/watch_queue.c b/kernel/watch_queue.c index 7e45559521af..52f89f1137da 100644 --- a/kernel/watch_queue.c +++ b/kernel/watch_queue.c @@ -119,9 +119,9 @@ static bool post_one_notification(struct watch_queue *wqueue, offset = note % WATCH_QUEUE_NOTES_PER_PAGE * WATCH_QUEUE_NOTE_SIZE; get_page(page); len = n->info & WATCH_INFO_LENGTH; - p = kmap_atomic(page); + p = kmap_local_page(page); memcpy(p + offset, n, len); - kunmap_atomic(p); + kunmap_local(p); buf = pipe_buf(pipe, head); buf->page = page; |