summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSuraj Kandpal <suraj.kandpal@intel.com>2025-08-06 08:38:56 +0530
committerSuraj Kandpal <suraj.kandpal@intel.com>2025-08-06 11:43:42 +0530
commitcdaecac4fbcb2680e0c4e89f772f20b5bf132ea6 (patch)
tree966b6ee4bdd9fc0e899ca89c967a7debb6051e0b
parent73309ed9d598d35576431c4691813e080980df68 (diff)
drm/i915/scaler: Fix WA_14011503117
This introduces and uses a variable id which is just uninitialized. What really needs to be used is the scaler_id. Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> Reviewed-by: Nemesa Garg <nemesa.garg@intel.com> Link: https://lore.kernel.org/r/20250806030856.3514127-1-suraj.kandpal@intel.com
-rw-r--r--drivers/gpu/drm/i915/display/skl_scaler.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 1374fa94ff5c..cd7ebbeb9508 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -959,11 +959,12 @@ void adl_scaler_ecc_unmask(const struct intel_crtc_state *crtc_state)
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
const struct intel_crtc_scaler_state *scaler_state =
&crtc_state->scaler_state;
- int id;
if (!scaler_state && scaler_state->scaler_id == -1)
return;
- intel_de_write_fw(display, SKL_PS_ECC_STAT(crtc->pipe, id), 1);
+ intel_de_write_fw(display,
+ SKL_PS_ECC_STAT(crtc->pipe, scaler_state->scaler_id),
+ 1);
intel_de_write(display, XELPD_DISPLAY_ERR_FATAL_MASK, 0);
}