diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-04-09 14:00:35 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-04-09 13:47:45 +0100 |
| commit | e686365c0411275474527c2055ac133f2eb47526 (patch) | |
| tree | 90371e42de6ec277e8d85f961be0e539817cc9b4 /drivers/spi/spi-amd-pci.c | |
| parent | 7d7c47281cb57c722683131a35fe6edc5d5b0325 (diff) | |
spi: spi_amd: Fix an IS_ERR() vs NULL check in probe
The devm_ioremap() function returns NULL on error, it doesn't
return error pointers. Update the error checking to match.
Fixes: b644c2776652 ("spi: spi_amd: Add PCI-based driver for AMD HID2 SPI controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/0e0f5ede-8993-4fac-967c-51e46b095416@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-amd-pci.c')
| -rw-r--r-- | drivers/spi/spi-amd-pci.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-amd-pci.c b/drivers/spi/spi-amd-pci.c index e1ecab755fe9..e5faab414c17 100644 --- a/drivers/spi/spi-amd-pci.c +++ b/drivers/spi/spi-amd-pci.c @@ -46,8 +46,8 @@ static int amd_spi_pci_probe(struct pci_dev *pdev, io_base_addr = (io_base_addr & AMD_SPI_BASE_ADDR_MASK) + AMD_HID2_PCI_BAR_OFFSET; amd_spi->io_remap_addr = devm_ioremap(dev, io_base_addr, AMD_HID2_MEM_SIZE); - if (IS_ERR(amd_spi->io_remap_addr)) - return dev_err_probe(dev, PTR_ERR(amd_spi->io_remap_addr), + if (!amd_spi->io_remap_addr) + return dev_err_probe(dev, -ENOMEM, "ioremap of SPI registers failed\n"); dev_dbg(dev, "io_remap_address: %p\n", amd_spi->io_remap_addr); |