diff options
| author | Nathan Chancellor <nathan@kernel.org> | 2025-01-20 06:12:01 -0700 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2025-02-10 11:16:30 -0800 |
| commit | 509f8cb2fff927eeb5eb0ebdd410ec6f40430173 (patch) | |
| tree | 87d8b21faa318773a8945b97aaf1edb18764956a /security/apparmor/label.c | |
| parent | e6b087676954e36a7b1ed51249362bb499f8c1c2 (diff) | |
apparmor: Fix checking address of an array in accum_label_info()
clang warns:
security/apparmor/label.c:206:15: error: address of array 'new->vec' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
206 | AA_BUG(!new->vec);
| ~~~~~~^~~
The address of this array can never be NULL because it is not at the
beginning of a structure. Convert the assertion to check that the new
pointer is not NULL.
Fixes: de4754c801f4 ("apparmor: carry mediation check on label")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501191802.bDp2voTJ-lkp@intel.com/
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security/apparmor/label.c')
| -rw-r--r-- | security/apparmor/label.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/label.c b/security/apparmor/label.c index afded9996f61..79be2d3d604b 100644 --- a/security/apparmor/label.c +++ b/security/apparmor/label.c @@ -203,7 +203,7 @@ static void accum_label_info(struct aa_label *new) long u = FLAG_UNCONFINED; int i; - AA_BUG(!new->vec); + AA_BUG(!new); /* size == 1 is a profile and flags must be set as part of creation */ if (new->size == 1) |