diff options
| author | Colin Ian King <colin.i.king@gmail.com> | 2025-05-17 01:49:20 -0700 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2025-05-17 01:49:20 -0700 |
| commit | 44fbeeb3087ee2ddce39d261d0a26688c2e22742 (patch) | |
| tree | 7dd13a6763df0ce9d633d2ed46e9933deaf964db /security/apparmor/policy_unpack.c | |
| parent | e9ed1eb8f6217e53843d82ecf2d50f8d1a93e77c (diff) | |
apparmor: Fix incorrect profile->signal range check
The check on profile->signal is always false, the value can never be
less than 1 *and* greater than MAXMAPPED_SIG. Fix this by replacing
the logical operator && with ||.
Fixes: 84c455decf27 ("apparmor: add support for profiles to define the kill signal")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security/apparmor/policy_unpack.c')
| -rw-r--r-- | security/apparmor/policy_unpack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c index 459eb878c824..588dd1d5d364 100644 --- a/security/apparmor/policy_unpack.c +++ b/security/apparmor/policy_unpack.c @@ -919,7 +919,7 @@ static struct aa_profile *unpack_profile(struct aa_ext *e, char **ns_name) /* optional */ (void) aa_unpack_u32(e, &profile->signal, "kill"); - if (profile->signal < 1 && profile->signal > MAXMAPPED_SIG) { + if (profile->signal < 1 || profile->signal > MAXMAPPED_SIG) { info = "profile kill.signal invalid value"; goto fail; } |