From ca16b15e78f4dee1631c0a68693f5e7d9b3bb3ec Mon Sep 17 00:00:00 2001 From: Alexandre Courbot Date: Wed, 22 Oct 2025 19:50:58 +0900 Subject: gpu: nova-core: bitfield: remove BitOr implementation Using this operand can produce invalid values. It also doesn't bring any benefit as one can use the builder pattern to assemble a new value. Reported-by: Edwin Peer Link: https://lore.kernel.org/rust-for-linux/F3853912-2C1C-4F9B-89B0-3168689F35B3@nvidia.com/ Reviewed-by: Joel Fernandes Reviewed-by: Danilo Krummrich Signed-off-by: Alexandre Courbot Message-ID: <20251022-nova-bitfield-v1-3-73bc0988667b@nvidia.com> --- drivers/gpu/nova-core/bitfield.rs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'drivers/gpu/nova-core/bitfield.rs') diff --git a/drivers/gpu/nova-core/bitfield.rs b/drivers/gpu/nova-core/bitfield.rs index f113439c6501..16e143658c51 100644 --- a/drivers/gpu/nova-core/bitfield.rs +++ b/drivers/gpu/nova-core/bitfield.rs @@ -94,7 +94,7 @@ macro_rules! bitfield { // All rules below are helpers. // Defines the wrapper `$name` type, as well as its relevant implementations (`Debug`, - // `Default`, `BitOr`, and conversion to the value type) and field accessor methods. + // `Default`, and conversion to the value type) and field accessor methods. (@core $vis:vis $name:ident $storage:ty $(, $comment:literal)? { $($fields:tt)* }) => { $( #[doc=$comment] @@ -103,14 +103,6 @@ macro_rules! bitfield { #[derive(Clone, Copy)] $vis struct $name($storage); - impl ::core::ops::BitOr for $name { - type Output = Self; - - fn bitor(self, rhs: Self) -> Self::Output { - Self(self.0 | rhs.0) - } - } - impl ::core::convert::From<$name> for $storage { fn from(val: $name) -> $storage { val.0 -- cgit v1.2.3