diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-10-17 19:04:34 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-10-17 17:21:03 +0100 |
| commit | 0cc08c8130ac8f74419f99fe707dc193b7f79d86 (patch) | |
| tree | 2f2455d6745d33534c800ca952cfb3dc1446eb23 | |
| parent | d77daa49085b067137d0adbe3263f75a7ee13a1b (diff) | |
spi: aspeed: Fix an IS_ERR() vs NULL bug in probe()
The platform_get_resource() function doesn't return error pointers, it
returns NULL on error. Update the error checking to match.
Fixes: 64d87ccfae33 ("spi: aspeed: Only map necessary address window region")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aPJpEnfK31pHz8_w@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-aspeed-smc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c index f3a7189afd51..e8bd8fe6c4e7 100644 --- a/drivers/spi/spi-aspeed-smc.c +++ b/drivers/spi/spi-aspeed-smc.c @@ -865,9 +865,9 @@ static int aspeed_spi_probe(struct platform_device *pdev) return PTR_ERR(aspi->regs); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (IS_ERR(res)) { + if (!res) { dev_err(dev, "missing AHB memory\n"); - return PTR_ERR(res); + return -EINVAL; } aspi->ahb_window_size = resource_size(res); |