summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosh Poimboeuf <jpoimboe@kernel.org>2025-11-20 12:52:17 -0800
committerPeter Zijlstra <peterz@infradead.org>2025-11-21 10:04:08 +0100
commit16f366c5a68839736d3616b466f1738811408ec7 (patch)
treebc0c0998d3b6f3d07bb9a96e2f532c0b51d9ff3a
parent2c2acca2eabf53a954ed5aacef987bbf909b9f12 (diff)
objtool: Don't alias undefined symbols
Objtool is mistakenly aliasing all undefined symbols. That's obviously wrong, though it has no consequence since objtool happens to only use sym->alias for defined symbols. Fix it regardless. Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://patch.msgid.link/bc401173a7717757eee672fc1ca5a20451d77b86.1763671318.git.jpoimboe@kernel.org
-rw-r--r--tools/objtool/elf.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index fffca31d47ed..4f15643ad70c 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -492,8 +492,8 @@ static int elf_add_symbol(struct elf *elf, struct symbol *sym)
sym->len = sym->sym.st_size;
__sym_for_each(iter, &sym->sec->symbol_tree, sym->offset, sym->offset) {
- if (iter->offset == sym->offset && iter->type == sym->type &&
- iter->len == sym->len)
+ if (!is_undef_sym(iter) && iter->offset == sym->offset &&
+ iter->type == sym->type && iter->len == sym->len)
iter->alias = sym;
}