summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel del Castillo <delcastillodelarosadaniel@gmail.com>2025-11-04 20:37:50 +0100
committerAlexandre Courbot <acourbot@nvidia.com>2025-11-07 23:10:44 +0900
commit3577e265e4bdb09441941a52c1bf9dfd1e27d707 (patch)
tree8b787b654ad00f8da524a1d5791977e6e7a55733
parent571ce401a78ee9cb5992b74d36df1b6a8ffd4b16 (diff)
gpu: nova-core: Simplify `DmaObject::from_data` in nova-core/dma.rs
This patch solves one of the existing mentions of COHA, a task in the Nova task list about improving the `CoherentAllocation` API. It uses the `write` method from `CoherentAllocation`. Signed-off-by: Daniel del Castillo <delcastillodelarosadaniel@gmail.com> [acourbot@nvidia.com: set prefix to "gpu: nova-core:".] Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> Message-ID: <20251104193756.57726-3-delcastillodelarosadaniel@gmail.com>
-rw-r--r--drivers/gpu/nova-core/dma.rs19
1 files changed, 5 insertions, 14 deletions
diff --git a/drivers/gpu/nova-core/dma.rs b/drivers/gpu/nova-core/dma.rs
index 5b117aefdb15..7215398969da 100644
--- a/drivers/gpu/nova-core/dma.rs
+++ b/drivers/gpu/nova-core/dma.rs
@@ -30,20 +30,11 @@ impl DmaObject {
}
pub(crate) fn from_data(dev: &device::Device<device::Bound>, data: &[u8]) -> Result<Self> {
- Self::new(dev, data.len()).map(|mut dma_obj| {
- // TODO[COHA]: replace with `CoherentAllocation::write()` once available.
- // SAFETY:
- // - `dma_obj`'s size is at least `data.len()`.
- // - We have just created this object and there is no other user at this stage.
- unsafe {
- core::ptr::copy_nonoverlapping(
- data.as_ptr(),
- dma_obj.dma.start_ptr_mut(),
- data.len(),
- );
- }
-
- dma_obj
+ Self::new(dev, data.len()).and_then(|mut dma_obj| {
+ // SAFETY: We have just allocated the DMA memory, we are the only users and
+ // we haven't made the device aware of the handle yet.
+ unsafe { dma_obj.write(data, 0)? }
+ Ok(dma_obj)
})
}
}