summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAashish Sharma <aashish@aashishsharma.net>2025-11-19 13:16:13 +0800
committerJoerg Roedel <joerg.roedel@amd.com>2025-11-20 11:33:04 +0100
commit6b38a108eeb3936b21643191db535a35dd7c890b (patch)
treefe8b74ddfa7b305cf3c7d1589ac7b7a4f96816fc
parentcb3db5a39e2a6b6396df1780d39a250f649d2e3a (diff)
iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb
Invalidation hint (ih) in the function 'qi_desc_iotlb' is initialized to zero and never used. It is embedded in the 0th bit of the 'addr' parameter. Get the correct 'ih' value from there. Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition") Signed-off-by: Aashish Sharma <aashish@aashishsharma.net> Link: https://lore.kernel.org/r/20251009010903.1323979-1-aashish@aashishsharma.net Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
-rw-r--r--drivers/iommu/intel/iommu.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h
index 3056583d7f56..dcc5466d35f9 100644
--- a/drivers/iommu/intel/iommu.h
+++ b/drivers/iommu/intel/iommu.h
@@ -1097,7 +1097,7 @@ static inline void qi_desc_iotlb(struct intel_iommu *iommu, u16 did, u64 addr,
struct qi_desc *desc)
{
u8 dw = 0, dr = 0;
- int ih = 0;
+ int ih = addr & 1;
if (cap_write_drain(iommu->cap))
dw = 1;