diff options
| author | Len Bao <len.bao@gmx.us> | 2025-07-27 07:56:45 +0000 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2025-08-18 09:49:04 +0100 |
| commit | 6e3779e3c6f9dcc9267bf98bef70773a0b13dcbb (patch) | |
| tree | 4bc2fba1b09f042bedbcd17de9f725bd71f22163 /drivers/leds | |
| parent | f4fc2d87aa167e3da5333c3db6cf702db1f98c05 (diff) | |
leds: max77705: Function return instead of variable assignment
Coverity noticed that assigning value -EINVAL to 'ret' in the if
statement is useless because 'ret' is overwritten a few lines later.
However, after inspect the code, this warning reveals that we need to
return -EINVAL instead of the variable assignment. So, fix it.
Coverity-id: 1646104
Fixes: aebb5fc9a0d8 ("leds: max77705: Add LEDs support")
Signed-off-by: Len Bao <len.bao@gmx.us>
Link: https://lore.kernel.org/r/20250727075649.34496-1-len.bao@gmx.us
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-max77705.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/leds/leds-max77705.c b/drivers/leds/leds-max77705.c index 933cb4f19be9..b7403b3fcf5e 100644 --- a/drivers/leds/leds-max77705.c +++ b/drivers/leds/leds-max77705.c @@ -180,7 +180,7 @@ static int max77705_add_led(struct device *dev, struct regmap *regmap, struct fw ret = fwnode_property_read_u32(np, "reg", ®); if (ret || reg >= MAX77705_LED_NUM_LEDS) - ret = -EINVAL; + return -EINVAL; info = devm_kcalloc(dev, num_channels, sizeof(*info), GFP_KERNEL); if (!info) |