diff options
| author | Marc Kleine-Budde <mkl@pengutronix.de> | 2025-08-06 12:20:44 +0200 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2025-10-17 15:17:19 +0200 |
| commit | 91a55c72a821d106a588af4c28aec129dcbea5af (patch) | |
| tree | c4b85b2089bd624f7cbeb76bb0677dd7e4ce56c4 /drivers/net/can | |
| parent | b24b43522eb33c32ca2348354e2555685c8c4644 (diff) | |
can: m_can: m_can_get_berr_counter(): don't wake up controller if interface is down
If the interface is down, the CAN controller might be powered down, the
clock disabled, and/or it's external reset asserted.
Don't wake up the controller to read the CAN bus error counters, if the
interface is down.
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Link: https://patch.msgid.link/20251008-m_can-cleanups-v1-7-1784a18eaa84@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can')
| -rw-r--r-- | drivers/net/can/m_can/m_can.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 713d3df296df..eb856547ae7d 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -791,6 +791,10 @@ static int m_can_get_berr_counter(const struct net_device *dev, struct m_can_classdev *cdev = netdev_priv(dev); int err; + /* Avoid waking up the controller if the interface is down */ + if (!(dev->flags & IFF_UP)) + return 0; + err = m_can_clk_start(cdev); if (err) return err; |