diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-11-24 10:56:01 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-11-24 15:11:55 +0000 |
| commit | cb99656b7c4185953c9d272bbdab63c8aa651e6e (patch) | |
| tree | b4bad90771cb12c306757682a5335039e6c93a53 /drivers/spi/spi-microchip-core-spi.c | |
| parent | 43a3adb6dd39d98bf84e04569e7604be5e5c0d79 (diff) | |
spi: Fix potential uninitialized variable in probe()
If the device tree is messed up, then potentially the "protocol" string
could potentially be uninitialized. The property is supposed to default
to "motorola" so if the of_property_read_string() function returns
-EINVAL then default to "motorola".
Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Prajna Rajendra Kumar <prajna.rajendrakumar@microchip.com>
Link: https://patch.msgid.link/aSQPkfkiJ0w-FJMW@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-microchip-core-spi.c')
| -rw-r--r-- | drivers/spi/spi-microchip-core-spi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-microchip-core-spi.c b/drivers/spi/spi-microchip-core-spi.c index b8738190cdcb..16e0885474a0 100644 --- a/drivers/spi/spi-microchip-core-spi.c +++ b/drivers/spi/spi-microchip-core-spi.c @@ -295,10 +295,10 @@ static int mchp_corespi_transfer_one(struct spi_controller *host, static int mchp_corespi_probe(struct platform_device *pdev) { + const char *protocol = "motorola"; struct spi_controller *host; struct mchp_corespi *spi; struct resource *res; - const char *protocol; u32 num_cs, mode, frame_size; bool assert_ssel; int ret = 0; @@ -320,6 +320,8 @@ static int mchp_corespi_probe(struct platform_device *pdev) */ ret = of_property_read_string(pdev->dev.of_node, "microchip,protocol-configuration", &protocol); + if (ret && ret != -EINVAL) + return dev_err_probe(&pdev->dev, ret, "Error reading protocol-configuration\n"); if (strcmp(protocol, "motorola") != 0) return dev_err_probe(&pdev->dev, -EINVAL, "CoreSPI: protocol '%s' not supported by this driver\n", |