diff options
| author | Christian Brauner <brauner@kernel.org> | 2025-11-17 10:34:43 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-11-19 21:58:26 +0100 |
| commit | 89a11f004f5e3806966cb0e522c4b975bbccc3a4 (patch) | |
| tree | 7ddc0d376f01582dc642b61fb3abe79752d949b1 /fs/overlayfs | |
| parent | e566bff963220ba0f740da42d46dd55c34ef745e (diff) | |
ovl: drop ovl_setup_cred_for_create()
It is now unused and can be removed.
Link: https://patch.msgid.link/20251117-work-ovl-cred-guard-prepare-v2-6-bd1c97a36d7b@kernel.org
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/overlayfs')
| -rw-r--r-- | fs/overlayfs/dir.c | 33 |
1 files changed, 0 insertions, 33 deletions
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index 6cfa7857b352..0f01e005b915 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -617,39 +617,6 @@ DEFINE_CLASS(ovl_override_creator_creds, ovl_override_creator_creds(dentry, inode, mode), struct dentry *dentry, struct inode *inode, umode_t mode) -static const __maybe_unused struct cred *ovl_setup_cred_for_create(struct dentry *dentry, - struct inode *inode, - umode_t mode, - const struct cred *old_cred) -{ - int err; - struct cred *override_cred; - - override_cred = prepare_creds(); - if (!override_cred) - return ERR_PTR(-ENOMEM); - - override_cred->fsuid = inode->i_uid; - override_cred->fsgid = inode->i_gid; - err = security_dentry_create_files_as(dentry, mode, &dentry->d_name, - old_cred, override_cred); - if (err) { - put_cred(override_cred); - return ERR_PTR(err); - } - - /* - * Caller is going to match this with revert_creds() and drop - * referenec on the returned creds. - * We must be called with creator creds already, otherwise we risk - * leaking creds. - */ - old_cred = override_creds(override_cred); - WARN_ON_ONCE(old_cred != ovl_creds(dentry->d_sb)); - - return override_cred; -} - static int ovl_create_handle_whiteouts(struct dentry *dentry, struct inode *inode, struct ovl_cattr *attr) |