summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2025-11-21 16:36:38 +0300
committerAndrew Morton <akpm@linux-foundation.org>2025-11-24 15:08:55 -0800
commita9ce09b15761e0f3a413a4a79097d17e19bd3ec1 (patch)
treee80b0be55c5700350c5eb44edfd726ee031738e0 /mm
parent348ced3da52b3161f5ceec8868e81973ce48e11d (diff)
mm/damon/tests/sysfs-kunit: fix use after free on error path
Re-order these frees to avoid dereferencing "sysfs_target" after it has been freed. Link: https://lkml.kernel.org/r/aSBq5uSPIqsqH8zO@stanley.mountain Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: SeongJae Park <sj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/damon/tests/sysfs-kunit.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/damon/tests/sysfs-kunit.h b/mm/damon/tests/sysfs-kunit.h
index ce7218469f20..0c665ed255a3 100644
--- a/mm/damon/tests/sysfs-kunit.h
+++ b/mm/damon/tests/sysfs-kunit.h
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test)
if (!ctx) {
kfree(sysfs_targets->targets_arr);
kfree(sysfs_targets);
- kfree(sysfs_target);
kfree(sysfs_target->regions);
+ kfree(sysfs_target);
kunit_skip(test, "ctx alloc fail");
}