summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/drivers/net/lib/py/load.py
diff options
context:
space:
mode:
authorGal Pressman <gal@nvidia.com>2025-07-23 16:54:54 +0300
committerJakub Kicinski <kuba@kernel.org>2025-07-24 18:52:00 -0700
commitd74cd9a02f020a6263b12a4c9e0f846b679a2f13 (patch)
tree7adb0312f74a1f10d5c5b79cf66f11664e52b997 /tools/testing/selftests/drivers/net/lib/py/load.py
parentb4d52c698210ae1a3ceb487b189701bc70551a48 (diff)
selftests: drv-net: Make command requirements explicit
Make require_cmd() calls explicit about whether commands are needed locally, remotely, or both. Since require_cmd() defaults to local=True, tests should explicitly set local=False when commands are only needed remotely. - socat: Set local=False since it's only needed on remote hosts. - iperf3: Use single call with both local=True and remote=True since it's needed on both hosts. This avoids unnecessary test failures when commands are missing locally but available remotely where actually needed, and consolidates a duplicate require_cmd() call into single call that checks both hosts. Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test") Fixes: f1e68a1a4a40 ("selftests: drv-net: add require_XYZ() helpers for validating env") Fixes: c76bab22e920 ("selftests: drv-net: rss_input_xfrm: Check test prerequisites before running") Reviewed-by: Nimrod Oren <noren@nvidia.com> Signed-off-by: Gal Pressman <gal@nvidia.com> Link: https://patch.msgid.link/20250723135454.649342-3-gal@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/testing/selftests/drivers/net/lib/py/load.py')
-rw-r--r--tools/testing/selftests/drivers/net/lib/py/load.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/drivers/net/lib/py/load.py b/tools/testing/selftests/drivers/net/lib/py/load.py
index 44151b7b1a24..c4e808407cc4 100644
--- a/tools/testing/selftests/drivers/net/lib/py/load.py
+++ b/tools/testing/selftests/drivers/net/lib/py/load.py
@@ -7,7 +7,7 @@ from lib.py import ksft_pr, cmd, ip, rand_port, wait_port_listen
class GenerateTraffic:
def __init__(self, env, port=None):
- env.require_cmd("iperf3", remote=True)
+ env.require_cmd("iperf3", local=True, remote=True)
self.env = env